implement DatumPass, Element and Scalar for Uuid#2358
Open
ibotty wants to merge 1 commit into
Open
Conversation
eeeebbbbrrrr
approved these changes
Jul 15, 2026
Comment on lines
+123
to
+125
| // Uuid is a fixed 16-byte, char-aligned, by-ref type stored inline in arrays with no | ||
| // header and no byte-swapping, so the macro's size>Datum big-endian branch (ptr.cast()) is | ||
| // correct for it. |
Contributor
There was a problem hiding this comment.
this editorialization is unnecessary
Comment on lines
+441
to
+443
| // Uuid is a fixed 16-byte `[u8; 16]` (no padding, all bitpatterns valid). Postgres stores `uuid` | ||
| // inline in arrays as packed, char-aligned raw bytes with no per-element header and no endian | ||
| // byte-swapping, so `&[Uuid]` matches the array data layout on both LE and BE. |
eeeebbbbrrrr
requested changes
Jul 15, 2026
eeeebbbbrrrr
left a comment
eeeebbbbrrrr
left a comment
Contributor
There was a problem hiding this comment.
please see my comments
ibotty
force-pushed
the
add-uuid-scalar-impl
branch
from
July 15, 2026 16:54
e7b1707 to
4bdd9b2
Compare
Author
|
I think the change is semantically correct, but I am no expert in PostgreSQL. I mostly went from Uuid (in PostgreSQL) is basically a i128 (and I am using it as that at times) to this should definitely work. I only briefly looked into the PostgreSQL code myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2357